From 90251023d44d50973e956d308b29a53ae84668e3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Pali=20Roh=C3=A1r?= Date: Wed, 28 Feb 2024 01:06:38 +0100 Subject: [PATCH] windows: Correctly propagate error code from win32_call_func_with_tcb_privilege() Cleanup phase may change error code as it calls other WinAPI functions. --- lib/win32-helpers.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/win32-helpers.c b/lib/win32-helpers.c index d370d5c..5338efa 100644 --- a/lib/win32-helpers.c +++ b/lib/win32-helpers.c @@ -1227,6 +1227,7 @@ win32_call_func_with_tcb_privilege(BOOL (*function)(LPVOID), LPVOID argument) HANDLE lsass_process; HANDLE lsass_token; + DWORD error; BOOL ret; impersonate_privilege_enabled = FALSE; @@ -1374,6 +1375,8 @@ err_privilege_not_held: goto ret; ret: + error = GetLastError(); + if (revert_to_old_token) win32_revert_to_token(old_token); @@ -1383,5 +1386,7 @@ ret: if (lsass_token) CloseHandle(lsass_token); + SetLastError(error); + return ret; } -- 2.39.2