From 39ae5e29879dc1beb00400a22229d8ff22d9cdd4 Mon Sep 17 00:00:00 2001
From: Robert Kessl <kesslr@centrum.cz>
Date: Mon, 28 Jul 2014 13:51:17 +0200
Subject: [PATCH] xtypes: removal of strtoul from size/timestamp parser

---
 ucw/table-types.c | 37 +++++++++++--------------------------
 ucw/xtypes-test.t | 16 ++++++++--------
 2 files changed, 19 insertions(+), 34 deletions(-)

diff --git a/ucw/table-types.c b/ucw/table-types.c
index b483ec55..84d317c2 100644
--- a/ucw/table-types.c
+++ b/ucw/table-types.c
@@ -7,10 +7,10 @@
 #include <ucw/lib.h>
 #include <ucw/table-types.h>
 #include <ucw/fastbuf.h>
+#include <ucw/strtonum.h>
 #include <ucw/table.h>
 #include <time.h>
 #include <stdio.h>
-#include <stdlib.h>
 #include <inttypes.h>
 #include <errno.h>
 
@@ -100,19 +100,11 @@ static const char *xt_size_fmt_parse(const char *opt_str, u32 *dest, struct memp
 static const char *xt_size_parse(const char *str, void *dest, struct mempool *pool)
 {
   errno = 0;
-  char *units_start = NULL;
-  // FIXME: Use str_to_u64() here to avoid troubles with strtoul()
-  // FIXME: Besides, who promises that u64 fits in unsigned long int?
-  u64 parsed = strtoul(str, &units_start, 10);
-  if(str == units_start) {
-    return mp_printf(pool, "Invalid value of size: '%s'.", str);
-  }
-
-  if(errno == EINVAL) {
-    return "Error occured during parsing of size.";
-  }
-  if(errno == ERANGE) {
-    return "Error: size value either too large or too small.";
+  const char *units_start = NULL;
+  u64 parsed;
+  const char *err = str_to_u64(&parsed, str, &units_start, 10 | STN_FLAGS);
+  if(err != NULL) {
+    return mp_printf(pool, "Invalid value of size: '%s'; number parser error: %s.", str, err);
   }
 
   if(*units_start == 0) {
@@ -122,7 +114,7 @@ static const char *xt_size_parse(const char *str, void *dest, struct mempool *po
 
   int unit_idx = xtype_unit_parser(units_start, xt_size_units);
   if(unit_idx == -1) {
-    return mp_printf(pool, "Invalid units: '%s'.", units_start);
+    return mp_printf(pool, "Invalid units: '%s'.", str);
   }
 
   // FIXME: Detect overflow?
@@ -189,18 +181,11 @@ static const char *xt_timestamp_fmt_parse(const char *opt_str, u32 *dest, struct
 static const char *xt_timestamp_parse(const char *str, void *dest, struct mempool *pool)
 {
   errno = 0;
-  char *parse_end = NULL;
-  // FIXME: Again, why strtoul()?
-  u64 parsed = strtoul(str, &parse_end, 10);
+  const char *parse_end = NULL;
+  u64 parsed;
+  const char *err = str_to_u64(&parsed, str, &parse_end, 10 | STN_FLAGS);
   if(str == parse_end) {
-    return mp_printf(pool, "Invalid value of timestamp: '%s'.", str);
-  }
-  if(errno == EINVAL) {
-    return "Error occured during parsing of size.";
-  }
-
-  if(errno == ERANGE) {
-    return "Error: size value either too large or too small.";
+    return mp_printf(pool, "Invalid value of timestamp: '%s'; number parser error: %s.", str, err);
   }
 
   if(*parse_end == 0) {
diff --git a/ucw/xtypes-test.t b/ucw/xtypes-test.t
index 3480a3ad..86a00bf6 100644
--- a/ucw/xtypes-test.t
+++ b/ucw/xtypes-test.t
@@ -5,12 +5,12 @@ Out <<EOF
 4MB 4MB
 4GB 4GB
 4TB 4TB
-xt_size.parse error: 'Invalid units: 'X'.'.
-xt_size.parse error: 'Invalid value of size: 'KB'.'.
-xt_size.parse error: 'Invalid value of size: 'X1KB'.'.
-xt_size.parse error: 'Invalid units: 'XKB'.'.
-xt_size.parse error: 'Invalid units: 'KBX'.'.
-xt_size.parse error: 'Invalid value of size: ''.'.
+xt_size.parse error: 'Invalid units: '1X'.'.
+xt_size.parse error: 'Invalid value of size: 'KB'; number parser error: Number contains no digits.'.
+xt_size.parse error: 'Invalid value of size: 'X1KB'; number parser error: Number contains no digits.'.
+xt_size.parse error: 'Invalid units: '1XKB'.'.
+xt_size.parse error: 'Invalid units: '1KBX'.'.
+xt_size.parse error: 'Invalid value of size: ''; number parser error: Number contains no digits.'.
 0 false
 1 true
 false false
@@ -21,8 +21,8 @@ xt_timestamp.parse error: 'Invalid value of timestamp: '1403685533X'.'.
 xt_timestamp.parse error: 'Invalid value of timestamp: '2014X-06-25 08:38:53'.'.
 xt_timestamp.parse error: 'Invalid value of timestamp: '2X014-06-25 08:38:53'.'.
 xt_timestamp.parse error: 'Invalid value of timestamp: '2014-06-25 08:38:53X'.'.
-xt_timestamp.parse error: 'Invalid value of timestamp: 'X2014-06-25 08:38:53'.'.
-xt_timestamp.parse error: 'Invalid value of timestamp: 'X1403685533'.'.
+xt_timestamp.parse error: 'Invalid value of timestamp: 'X2014-06-25 08:38:53'; number parser error: Number contains no digits.'.
+xt_timestamp.parse error: 'Invalid value of timestamp: 'X1403685533'; number parser error: Number contains no digits.'.
 xt_timestamp.parse error: 'Invalid value of timestamp: '14X03685533'.'.
 xt_timestamp.parse error: 'Invalid value of timestamp: '1403685533X'.'.
 EOF
-- 
2.39.2