]> mj.ucw.cz Git - libucw.git/log
libucw.git
9 years agotableprinter: code cleanup, update of usage of table_set_col_opt
Robert Kessl [Fri, 25 Jul 2014 14:27:59 +0000 (16:27 +0200)]
tableprinter: code cleanup, update of usage of table_set_col_opt

 - update of usage of col_idx: now we discriminate between col_def_idx
   for column definition index and col_inst_idx.
 - default value of table_column::set_col_opt is now NULL and the table_set_col_opt should
   be used by user

9 years agotableprinter: code cleanup
Robert Kessl [Fri, 25 Jul 2014 13:16:17 +0000 (15:16 +0200)]
tableprinter: code cleanup

9 years agotableprinter: removal of table_make_instance
Robert Kessl [Fri, 25 Jul 2014 13:13:27 +0000 (15:13 +0200)]
tableprinter: removal of table_make_instance

9 years agotableprinter: code cleanup
Robert Kessl [Fri, 25 Jul 2014 13:07:59 +0000 (15:07 +0200)]
tableprinter: code cleanup

 - removed last_printed_col
 - update of initialization of column orders in table_set_col_order
 - update of table_set_col_opt: called die if table_column::set_col_opt
   is a pointer to table_set_col_opt.
 - update of documentation of table_set_col_opt

9 years agoMerge remote-tracking branch 'origin/dev-table' into dev-table
Robert Kessl [Fri, 25 Jul 2014 12:20:16 +0000 (14:20 +0200)]
Merge remote-tracking branch 'origin/dev-table' into dev-table

9 years agotableprinter: renamed data to formatter_data
Robert Kessl [Fri, 25 Jul 2014 12:20:09 +0000 (14:20 +0200)]
tableprinter: renamed data to formatter_data

9 years agoTable printer: Review comments
Martin Mares [Fri, 25 Jul 2014 12:01:52 +0000 (14:01 +0200)]
Table printer: Review comments

9 years agoExtended types: Review and cleanup of xt_size and xt_timestamp
Martin Mares [Fri, 25 Jul 2014 11:47:12 +0000 (13:47 +0200)]
Extended types: Review and cleanup of xt_size and xt_timestamp

  •  Adapted to naming convention on custom formatting modes.

  •  Use macro to wrap unit in a formatting mode, like we already
     do in XT_DOUBLE_FMT_PREC. Besides, encode such modes as proper
     custom modes with XTYPE_FMT_CUSTOM set.

  •  Do not check for NULL in parsing functions, it makes no sense
     (that is, the program would already have crashed before getting
     there with a NULL argument). If you really want to check for
     NULLs, do it in generic parsing functions, which call these
     callbacks.

  •  Do not mix definitions related to xt_size and xt_timestamp
     in the header file.

  •  Cleaned up selection of units in xt_size_format().

  •  Added a bunch of FIXMEs.

9 years agoExtended types: Introduced naming convention for xtype format macros
Martin Mares [Fri, 25 Jul 2014 11:25:34 +0000 (13:25 +0200)]
Extended types: Introduced naming convention for xtype format macros

For xt_something, let's use XT_SOMETHING_FMT_...

9 years agoExtended types: Moved unit tables to a more logical place in the header
Martin Mares [Fri, 25 Jul 2014 11:11:16 +0000 (13:11 +0200)]
Extended types: Moved unit tables to a more logical place in the header

9 years agoExtended types: Cleaned up unit name parsing
Martin Mares [Fri, 25 Jul 2014 11:04:27 +0000 (13:04 +0200)]
Extended types: Cleaned up unit name parsing

First of all, please show some respect and don't mess up coding
style of existing source files.

Second, when all parsing functions in xtypes.h use a common name
for the input string, just use it, too.

9 years agoExtended types: Keep includes sorted
Martin Mares [Fri, 25 Jul 2014 10:52:02 +0000 (12:52 +0200)]
Extended types: Keep includes sorted

9 years agoExtended types: Let unknown formats behave as XTYPE_FMT_DEFAULT
Martin Mares [Fri, 25 Jul 2014 10:50:28 +0000 (12:50 +0200)]
Extended types: Let unknown formats behave as XTYPE_FMT_DEFAULT

Otherwise, it would be very hard to define new common formats
in the future.

9 years agoExtended types: Cleanup of xt_double
Martin Mares [Fri, 25 Jul 2014 10:49:22 +0000 (12:49 +0200)]
Extended types: Cleanup of xt_double

9 years agoExtended types: Miscellaneous fixes of xt_bool
Martin Mares [Fri, 25 Jul 2014 10:42:29 +0000 (12:42 +0200)]
Extended types: Miscellaneous fixes of xt_bool

  •  Streamlined code and unified coding style.

  •  xt_bool_format() returns static strings, there is no need
     to duplicate them.

  •  xt_bool_parse() returns a more reasonable error message.

  •  Invalid formatting mode is an internal error, which should not
     be triggerable by the user, so ASSERT is enough.

9 years agoExtended types: Parsing of xt_str now copies the string
Martin Mares [Fri, 25 Jul 2014 10:38:18 +0000 (12:38 +0200)]
Extended types: Parsing of xt_str now copies the string

9 years agotableprinter&xtypes: size now supports auto units
Robert Kessl [Thu, 24 Jul 2014 12:53:50 +0000 (14:53 +0200)]
tableprinter&xtypes: size now supports auto units

9 years agotableprinter&xtypes: update of ABI
Robert Kessl [Thu, 24 Jul 2014 08:26:37 +0000 (10:26 +0200)]
tableprinter&xtypes: update of ABI

9 years agotableprinter: size units are now static
Robert Kessl [Thu, 24 Jul 2014 08:15:35 +0000 (10:15 +0200)]
tableprinter: size units are now static

9 years agoTableprinter: rename of table_set_all_inst_content -> table_set_raw
Robert Kessl [Thu, 24 Jul 2014 07:54:25 +0000 (09:54 +0200)]
Tableprinter: rename of table_set_all_inst_content -> table_set_raw

9 years agotableprinter: TBL_COL_CUSTOM renamed to TBL_COL_XTYPE
Robert Kessl [Thu, 24 Jul 2014 07:32:00 +0000 (09:32 +0200)]
tableprinter: TBL_COL_CUSTOM renamed to TBL_COL_XTYPE

9 years agoxtypes: bool now supports yes/no strings
Robert Kessl [Thu, 24 Jul 2014 06:49:09 +0000 (08:49 +0200)]
xtypes: bool now supports yes/no strings

9 years agotableprinter: code cleanup
Robert Kessl [Thu, 24 Jul 2014 06:47:49 +0000 (08:47 +0200)]
tableprinter: code cleanup

9 years agoxtypes&tableprinter: update of tests
Robert Kessl [Wed, 23 Jul 2014 14:16:30 +0000 (16:16 +0200)]
xtypes&tableprinter: update of tests

9 years agotableprinter: update of tests and size/timestamp parser
Robert Kessl [Wed, 23 Jul 2014 14:11:52 +0000 (16:11 +0200)]
tableprinter: update of tests and size/timestamp parser

 - update of error messages for size/timestamp
 - strtol changed to strtoul (we should are using u64)
 - update of tests

9 years agoxtypes: update of tests, code cleanup
Robert Kessl [Wed, 23 Jul 2014 13:58:18 +0000 (15:58 +0200)]
xtypes: update of tests, code cleanup

9 years agotableprinter&xtypes: assert changed to die in tests, fix of timestamp parsing
Robert Kessl [Wed, 23 Jul 2014 12:52:41 +0000 (14:52 +0200)]
tableprinter&xtypes: assert changed to die in tests, fix of timestamp parsing

9 years agotableprinter: removed UNUSED attribute from timestamp&size parsing
Robert Kessl [Wed, 23 Jul 2014 12:39:45 +0000 (14:39 +0200)]
tableprinter: removed UNUSED attribute from timestamp&size parsing

9 years agoxtypes&tableprinter: fix of tests of parsing
Robert Kessl [Wed, 23 Jul 2014 12:10:14 +0000 (14:10 +0200)]
xtypes&tableprinter: fix of tests of parsing

9 years agoxtypes: first shot on tests of timestamp parsing
Robert Kessl [Wed, 23 Jul 2014 11:49:44 +0000 (13:49 +0200)]
xtypes: first shot on tests of timestamp parsing

9 years agoxtypes: added first shot on unit parser
Robert Kessl [Wed, 23 Jul 2014 10:10:10 +0000 (12:10 +0200)]
xtypes: added first shot on unit parser

9 years agoxtypes: updated tests
Robert Kessl [Tue, 22 Jul 2014 13:15:40 +0000 (15:15 +0200)]
xtypes: updated tests

9 years agoxtypes: fixed error in xt_bool parser
Robert Kessl [Tue, 22 Jul 2014 13:02:23 +0000 (15:02 +0200)]
xtypes: fixed error in xt_bool parser

9 years agoxtypes&tableprinter: added parsing of size and tests
Robert Kessl [Tue, 22 Jul 2014 12:54:17 +0000 (14:54 +0200)]
xtypes&tableprinter: added parsing of size and tests

9 years agotableprinter: header option now parsed by xtypes
Robert Kessl [Tue, 22 Jul 2014 11:08:18 +0000 (13:08 +0200)]
tableprinter: header option now parsed by xtypes

9 years agotableprinter: code cleanup
Robert Kessl [Tue, 22 Jul 2014 10:46:29 +0000 (12:46 +0200)]
tableprinter: code cleanup

9 years agotableprinter: some ints in struct table changed to bool
Robert Kessl [Tue, 22 Jul 2014 10:20:48 +0000 (12:20 +0200)]
tableprinter: some ints in struct table changed to bool

9 years agotableprinter: updated setting of column option
Robert Kessl [Tue, 22 Jul 2014 10:12:19 +0000 (12:12 +0200)]
tableprinter: updated setting of column option

9 years agotableprinter: update of parsing of column options
Robert Kessl [Tue, 22 Jul 2014 08:38:03 +0000 (10:38 +0200)]
tableprinter: update of parsing of column options

9 years agoxtypes: update of default formatting
Robert Kessl [Mon, 21 Jul 2014 12:49:46 +0000 (14:49 +0200)]
xtypes: update of default formatting

9 years agotableprinter: renamed output_type -> fmt, changed bool default format
Robert Kessl [Mon, 21 Jul 2014 12:07:10 +0000 (14:07 +0200)]
tableprinter: renamed output_type -> fmt, changed bool default format

9 years agoMerge branch 'master' into dev-table
Robert Kessl [Mon, 21 Jul 2014 10:40:57 +0000 (12:40 +0200)]
Merge branch 'master' into dev-table

Conflicts:
ucw/table.h

9 years agotableprinter: code cleanup, added options
Robert Kessl [Mon, 21 Jul 2014 10:38:48 +0000 (12:38 +0200)]
tableprinter: code cleanup, added options

 - renamed TBL_OUTPUT_* -> TBL_FMT_*
 - added "raw" and "pretty" table option
 - added "cells" table option

9 years agotableprinter: table_update_ll now uses .idx
Robert Kessl [Mon, 21 Jul 2014 07:39:25 +0000 (09:39 +0200)]
tableprinter: table_update_ll now uses .idx

9 years agotableprinter: code cleanup
Robert Kessl [Mon, 21 Jul 2014 07:28:00 +0000 (09:28 +0200)]
tableprinter: code cleanup

9 years agotableprinter: formatters are now const
Robert Kessl [Mon, 21 Jul 2014 07:23:16 +0000 (09:23 +0200)]
tableprinter: formatters are now const

9 years agotableprinter: table_set_col_order_by_name now calls table_make_default_column_order
Robert Kessl [Mon, 21 Jul 2014 07:06:00 +0000 (09:06 +0200)]
tableprinter: table_set_col_order_by_name now calls table_make_default_column_order

9 years agoMerge remote-tracking branch 'origin/dev-table' into dev-table
Robert Kessl [Fri, 18 Jul 2014 12:00:53 +0000 (14:00 +0200)]
Merge remote-tracking branch 'origin/dev-table' into dev-table

9 years agoxtypes: update of parsing/formatting of xt_double
Robert Kessl [Fri, 18 Jul 2014 12:00:12 +0000 (14:00 +0200)]
xtypes: update of parsing/formatting of xt_double

9 years agotableprinter: return value of table_set_col_opt changed to int
Robert Kessl [Fri, 18 Jul 2014 11:57:30 +0000 (13:57 +0200)]
tableprinter: return value of table_set_col_opt changed to int

9 years agotableprinter: removed unnecessary macros, code cleanup
Robert Kessl [Fri, 18 Jul 2014 11:55:32 +0000 (13:55 +0200)]
tableprinter: removed unnecessary macros, code cleanup

9 years agotableprinter: code cleanup
Robert Kessl [Fri, 18 Jul 2014 11:52:04 +0000 (13:52 +0200)]
tableprinter: code cleanup

9 years agoTableprinter: Fixed a tiny typo
Martin Mares [Fri, 18 Jul 2014 10:52:24 +0000 (12:52 +0200)]
Tableprinter: Fixed a tiny typo

9 years agotableprinter: fix of error messages.
Robert Kessl [Thu, 17 Jul 2014 12:02:49 +0000 (14:02 +0200)]
tableprinter: fix of error messages.

9 years agoxtypes: bugfix in xt_bool_parse, code cleanup
Robert Kessl [Thu, 17 Jul 2014 11:54:50 +0000 (13:54 +0200)]
xtypes: bugfix in xt_bool_parse, code cleanup

9 years agoMerge remote-tracking branch 'origin/dev-table' into dev-table
Robert Kessl [Thu, 17 Jul 2014 11:52:15 +0000 (13:52 +0200)]
Merge remote-tracking branch 'origin/dev-table' into dev-table

9 years agotableprinter: doc update, code cleanup
Robert Kessl [Thu, 17 Jul 2014 11:51:52 +0000 (13:51 +0200)]
tableprinter: doc update, code cleanup

9 years agoxtypes: Added FIXME with possible segfault.
Pavel Charvat [Thu, 17 Jul 2014 08:53:54 +0000 (10:53 +0200)]
xtypes: Added FIXME with possible segfault.

9 years agoxtypes: Small code cleanups.
Pavel Charvat [Thu, 17 Jul 2014 08:52:46 +0000 (10:52 +0200)]
xtypes: Small code cleanups.

9 years agotableprinter: removed column type macros
Robert Kessl [Wed, 16 Jul 2014 14:57:04 +0000 (16:57 +0200)]
tableprinter: removed column type macros

9 years agotableprinter: code cleanup
Robert Kessl [Wed, 16 Jul 2014 14:25:24 +0000 (16:25 +0200)]
tableprinter: code cleanup

9 years agotableprinter: update of linked list and usage of const
Robert Kessl [Wed, 16 Jul 2014 12:50:11 +0000 (14:50 +0200)]
tableprinter: update of linked list and usage of const

9 years agotableprinter: update of xtypes for tableprinter
Robert Kessl [Wed, 16 Jul 2014 11:41:52 +0000 (13:41 +0200)]
tableprinter: update of xtypes for tableprinter

9 years agotableprinter: updated table_col_<type> funcs, update of mem allocation
Robert Kessl [Wed, 16 Jul 2014 08:58:06 +0000 (10:58 +0200)]
tableprinter: updated table_col_<type> funcs, update of mem allocation

9 years agotableprinter: started fixing of setting cell values
Robert Kessl [Wed, 16 Jul 2014 07:40:19 +0000 (09:40 +0200)]
tableprinter: started fixing of setting cell values

9 years agotableprinter: code cleanup, update of formats of double
Robert Kessl [Tue, 15 Jul 2014 12:35:33 +0000 (14:35 +0200)]
tableprinter: code cleanup, update of formats of double

9 years agotableprinter: update of TABLE_COL_BODIES macro, code cleanup
Robert Kessl [Tue, 15 Jul 2014 11:06:24 +0000 (13:06 +0200)]
tableprinter: update of TABLE_COL_BODIES macro, code cleanup

 - TABLE_COL_BODIES macros moved to table.h
 - removed undef of TABLE_COL_PROTO in table.h
 - code cleanup
 - added xtypes.h to header list in Makefile

9 years agoxtypes: bugfixes in printf format and incorrect use of errno
Robert Kessl [Mon, 14 Jul 2014 09:16:01 +0000 (11:16 +0200)]
xtypes: bugfixes in printf format and incorrect use of errno

9 years agoxtypes&tableprinter: basic cleanup
Robert Kessl [Mon, 14 Jul 2014 08:36:54 +0000 (10:36 +0200)]
xtypes&tableprinter: basic cleanup

9 years agoxtype&tableprinter: first shot on incorporating xtypes to tableprinter
Robert Kessl [Mon, 14 Jul 2014 08:14:43 +0000 (10:14 +0200)]
xtype&tableprinter: first shot on incorporating xtypes to tableprinter

9 years agoExtended types: First attempt at interface
Martin Mares [Thu, 10 Jul 2014 14:04:44 +0000 (16:04 +0200)]
Extended types: First attempt at interface

9 years agotableprinter: added a FIXME comment
Robert Kessl [Thu, 10 Jul 2014 08:18:22 +0000 (10:18 +0200)]
tableprinter: added a FIXME comment

9 years agotableprinter: update of size units
Robert Kessl [Thu, 10 Jul 2014 08:17:17 +0000 (10:17 +0200)]
tableprinter: update of size units

9 years agotableprinter: fix of table_make_instance, incorrect initialization of column order
Robert Kessl [Thu, 10 Jul 2014 08:16:28 +0000 (10:16 +0200)]
tableprinter: fix of table_make_instance, incorrect initialization of column order

9 years agotableprinter: renamed size units; update of doc
Robert Kessl [Wed, 9 Jul 2014 15:23:46 +0000 (17:23 +0200)]
tableprinter: renamed size units; update of doc

9 years agotableprinter: code cleanup contd.
Robert Kessl [Wed, 9 Jul 2014 14:12:23 +0000 (16:12 +0200)]
tableprinter: code cleanup contd.

 - update of cell output types: CELL_OUT_UNINITIALIZED is -1, CELL_OUT_HUMAN_READABLE is now -2 and CELL_OUT_MACHINE_READABLE -3
 - table_col_bool* now uses bool instead of uint
 - other code cleanup

9 years agotableprinter: code cleanup contd.
Robert Kessl [Wed, 9 Jul 2014 11:42:08 +0000 (13:42 +0200)]
tableprinter: code cleanup contd.

 - renamed table_col_info -> table_col_instance
 - table_init now uses const for struct table_template
 - some initialization moved from table_init to table_make_instance

9 years agotableprinter: update of linked list
Robert Kessl [Wed, 9 Jul 2014 10:45:43 +0000 (12:45 +0200)]
tableprinter: update of linked list

9 years agotableprinter: code cleanup
Robert Kessl [Wed, 9 Jul 2014 08:36:02 +0000 (10:36 +0200)]
tableprinter: code cleanup

 - renamed table_set_all_cols_content -> table_set_all_inst_content
 - renamed  all UNIT_*, e.g., UNIT_BYTE -> UNIT_SIZE_BYTE
 - instead of using the word 'copy' for a column, now we use instance
 - removal of unnecessary ucw/config.h

9 years agotableprinter: allocation of handles now uses xmalloc_zero/xfree
Robert Kessl [Tue, 8 Jul 2014 11:40:57 +0000 (13:40 +0200)]
tableprinter: allocation of handles now uses xmalloc_zero/xfree

9 years agotableprinter: update of documentation
Robert Kessl [Tue, 8 Jul 2014 11:17:38 +0000 (13:17 +0200)]
tableprinter: update of documentation

9 years agotableprinter: definition of the table separated from handle
Robert Kessl [Tue, 8 Jul 2014 08:03:53 +0000 (10:03 +0200)]
tableprinter: definition of the table separated from handle

9 years agotableprinter: update of documentation
Robert Kessl [Mon, 7 Jul 2014 13:50:41 +0000 (15:50 +0200)]
tableprinter: update of documentation

9 years agotableprinter: table_init now makes a copy of its argument
Robert Kessl [Mon, 7 Jul 2014 13:18:05 +0000 (15:18 +0200)]
tableprinter: table_init now makes a copy of its argument

 - tableprinter now considers the argument to table_init as a template
   and makes a copy of it. Copy of the template (struct table) is allocated
   on the table template pool.
   - FIXME: documentation must be updated

9 years agotableprinter: update of tests
Robert Kessl [Mon, 7 Jul 2014 08:31:37 +0000 (10:31 +0200)]
tableprinter: update of tests

9 years agotableprinter: update of some FIXME
Robert Kessl [Mon, 7 Jul 2014 07:10:01 +0000 (09:10 +0200)]
tableprinter: update of some FIXME

10 years agotableprinter: bugfix in table_set_col_opt_size, incorrect handling of argument
Robert Kessl [Fri, 4 Jul 2014 14:22:50 +0000 (16:22 +0200)]
tableprinter: bugfix in table_set_col_opt_size, incorrect handling of argument

10 years agotableprinter: bugfix in TBL_COL_ITER macro
Robert Kessl [Fri, 4 Jul 2014 13:44:29 +0000 (15:44 +0200)]
tableprinter: bugfix in TBL_COL_ITER macro

10 years agotableprinter: update of iterator macro; bugfix in table_set_col_opt_size
Robert Kessl [Fri, 4 Jul 2014 13:02:24 +0000 (15:02 +0200)]
tableprinter: update of iterator macro; bugfix in table_set_col_opt_size

10 years agotableprinter: update of column iterator and table_set_col_opt_size
Robert Kessl [Fri, 4 Jul 2014 10:48:42 +0000 (12:48 +0200)]
tableprinter: update of column iterator and table_set_col_opt_size

10 years agotableprinter: bugfix in initialization macros
Robert Kessl [Fri, 4 Jul 2014 10:30:30 +0000 (12:30 +0200)]
tableprinter: bugfix in initialization macros

 - added forgotten type definition to TBL_COL_SIZE_FMT, TBL_COL_TIMESTAMP_FMT

10 years agotableprinter: hidding of column linked list internals
Robert Kessl [Fri, 4 Jul 2014 08:06:49 +0000 (10:06 +0200)]
tableprinter: hidding of column linked list internals

10 years agotableprinter: update of LU -> LLU
Robert Kessl [Wed, 2 Jul 2014 14:13:47 +0000 (16:13 +0200)]
tableprinter: update of LU -> LLU

10 years agotableprinter: fix of value override
Robert Kessl [Wed, 2 Jul 2014 14:01:37 +0000 (16:01 +0200)]
tableprinter: fix of value override

10 years agotableprinter: update of tests
Robert Kessl [Wed, 2 Jul 2014 14:00:17 +0000 (16:00 +0200)]
tableprinter: update of tests

10 years agotableprinter: bugfix in initialization macros
Robert Kessl [Wed, 2 Jul 2014 11:54:44 +0000 (13:54 +0200)]
tableprinter: bugfix in initialization macros

 - added forgotten type definition to TBL_COL_SIZE_FMT, TBL_COL_TIMESTAMP_FMT

10 years agotableprinter: code cleanup
Robert Kessl [Wed, 2 Jul 2014 11:52:22 +0000 (13:52 +0200)]
tableprinter: code cleanup

10 years agotableprinter: update of user-defined column types
Robert Kessl [Wed, 2 Jul 2014 11:51:43 +0000 (13:51 +0200)]
tableprinter: update of user-defined column types

 - added pointer to a definition of column to struct table_column
 - added definition of column with size and timestamp.

10 years agotableprinter: code cleanup; doc update
Robert Kessl [Wed, 2 Jul 2014 08:47:05 +0000 (10:47 +0200)]
tableprinter: code cleanup; doc update

10 years agotableprinter: added parsing of column arg; bugfixes
Robert Kessl [Tue, 1 Jul 2014 14:58:20 +0000 (16:58 +0200)]
tableprinter: added parsing of column arg; bugfixes

- added parsing of column args. Now it is possible to specify column
  using the following format: <col-name>['['<arg>']']
- fix of printing of timestamp and size: single value was set for all
  instances of a column. Now each column instance has value in its
  format.