From: Rudi Heitbaum <rudi@heitbaum.com>
Date: Sun, 22 Feb 2026 00:47:15 +0000 (+0000)
Subject: setpci: Fix discards const from pointer target
X-Git-Url: http://mj.ucw.cz/gitweb/?a=commitdiff_plain;h=f029c3ccc0389ad14136a1727eec8f93fdb4f9cb;p=pciutils.git

setpci: Fix discards const from pointer target

Since glibc-2.43, and for ISO C23, the function strchr that return
pointer into their input arrays now have definitions as macros that
return a pointer to a const-qualified type when the input argument is
a pointer to a const-qualified type.

The char *e is only used as a pointer to const char **opts, and only
used for comparisons, so declare *e as const to address warning.

Fixes:
    setpci.c: In function 'parse_options':
    setpci.c:513:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
      513 |             if (e = strchr(opts, *c))
          |                   ^

Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
---

diff --git a/setpci.c b/setpci.c
index 9ce2ed6..b833250 100644
--- a/setpci.c
+++ b/setpci.c
@@ -488,7 +488,7 @@ parse_options(int argc, char **argv)
     {
       char *c = argv[i++] + 1;
       char *d = c;
-      char *e;
+      const char *e;
       while (*c)
 	switch (*c)
 	  {