From: Martin Mares <mj@ucw.cz>
Date: Mon, 11 Dec 2006 22:44:43 +0000 (+0100)
Subject: Creation of temporary files is now thread-safe (ugh).
X-Git-Tag: holmes-import~507^2~16
X-Git-Url: http://mj.ucw.cz/gitweb/?a=commitdiff_plain;h=ca8ff59d75ed060ea7489c8b2e1ba24283a7afc8;p=libucw.git

Creation of temporary files is now thread-safe (ugh).
---

diff --git a/lib/fb-temp.c b/lib/fb-temp.c
index b8189ab9..aa1689c4 100644
--- a/lib/fb-temp.c
+++ b/lib/fb-temp.c
@@ -1,7 +1,7 @@
 /*
  *	UCW Library -- Temporary Fastbufs
  *
- *	(c) 2002--2004 Martin Mares <mj@ucw.cz>
+ *	(c) 2002--2006 Martin Mares <mj@ucw.cz>
  *
  *	This software may be freely distributed and used according to the terms
  *	of the GNU Lesser General Public License.
@@ -10,33 +10,68 @@
 #include "lib/lib.h"
 #include "lib/conf.h"
 #include "lib/fastbuf.h"
+#include "lib/threads.h"
 
 #include <unistd.h>
 #include <sys/fcntl.h>
 
-static byte *temp_template = "/tmp/temp%d.%d";
+static byte *temp_prefix = "/tmp/temp";
 
 static struct cf_section temp_config = {
   CF_ITEMS {
-    CF_STRING("Template", &temp_template),
+    CF_STRING("Prefix", &temp_prefix),
     CF_END
   }
 };
 
-static void CONSTRUCTOR temp_init_config(void)
+static void CONSTRUCTOR temp_global_init(void)
 {
   cf_declare_section("Tempfiles", &temp_config, 0);
 }
 
+void
+temp_file_name(byte *buf)
+{
+  int cnt = ++ucwlib_thread_context()->temp_counter;
+  int pid = getpid();
+#if 0
+  /* FIXME: This is Linux-specific and not declared anywhere :( */
+  int tid = gettid();
+#else
+  int tid = pid;
+#endif
+  if (pid == tid)
+    sprintf(buf, "%s%d-%d", temp_prefix, pid, cnt);
+  else
+    sprintf(buf, "%s%d-%d-%d", temp_prefix, pid, tid, cnt);
+}
+
 struct fastbuf *
 bopen_tmp(uns buflen)
 {
-  byte buf[256];
+  byte buf[TEMP_FILE_NAME_LEN];
   struct fastbuf *f;
-  static uns temp_counter;
 
-  sprintf(buf, temp_template, (int) getpid(), temp_counter++);
+  temp_file_name(buf);
   f = bopen(buf, O_RDWR | O_CREAT | O_TRUNC, buflen);
   bconfig(f, BCONFIG_IS_TEMP_FILE, 1);
   return f;
 }
+
+#ifdef TEST
+
+#include "lib/getopt.h"
+
+int main(int argc, char **argv)
+{
+  log_init(NULL);
+  if (cf_getopt(argc, argv, CF_SHORT_OPTS, CF_NO_LONG_OPTS, NULL) >= 0)
+    die("Hey, whaddya want?");
+
+  struct fastbuf *f = bopen_tmp(65536);
+  bputsn(f, "Hello, world!");
+  bclose(f);
+  return 0;
+}
+
+#endif