Added __attribute__((format...)) to declaration of log(), so that

discrepancies between format string and arguments get easily found.

diff --git a/lib/lib.h b/lib/lib.h
index 12d92e104322b2bbc1cdb782e657ed38e51ab517..b397c89b47c25152f799b00e21c8ea86b6bf12f2 100644 (file)
--- a/lib/lib.h
+++ b/lib/lib.h
@@ -54,7 +54,7 @@ u32 temprand(uns);
 #define L_ERROR_R      'e'
 #define L_FATAL                '!'             /* die() */
 
-void log(unsigned int cat, byte *msg, ...);
+void log(unsigned int cat, const char *msg, ...) __attribute__((format(printf,2,3)));
 void die(byte *, ...) NONRET;
 void log_init(byte *);
 void log_file(byte *);

diff --git a/lib/log.c b/lib/log.c
index f2440e803917303f6952c778eeee0bf061078302..bc74de5b93e30e250b5b345e7d4b699e794e3639 100644 (file)
--- a/lib/log.c
+++ b/lib/log.c
@@ -23,7 +23,7 @@ log_fork(void)
 }
 
 static void
-vlog(unsigned int cat, byte *msg, va_list args)
+vlog(unsigned int cat, const char *msg, va_list args)
 {
   time_t tim = time(NULL);
   struct tm *tm = localtime(&tim);
@@ -41,7 +41,7 @@ vlog(unsigned int cat, byte *msg, va_list args)
 }
 
 void
-log(unsigned int cat, byte *msg, ...)
+log(unsigned int cat, const char *msg, ...)
 {
   va_list args;