]> mj.ucw.cz Git - pciutils.git/commitdiff
pcilmr: No need to copy a string passed to filter parsing functions
authorMartin Mares <mj@ucw.cz>
Sun, 18 Feb 2024 11:08:21 +0000 (12:08 +0100)
committerMartin Mares <mj@ucw.cz>
Sun, 18 Feb 2024 11:08:21 +0000 (12:08 +0100)
The parsing is guaranteed to be non-destructive in recent libpci.

pcilmr.c

index bab2a07dd1259f722760468619fc527e7fab4bba..0d8b614516ed85e65cdb1b419d103dfaf7d7b55a 100644 (file)
--- a/pcilmr.c
+++ b/pcilmr.c
@@ -64,10 +64,8 @@ static struct pci_dev *
 dev_for_filter(struct pci_access *pacc, char *filter)
 {
   struct pci_filter pci_filter;
-  char dev[17] = { 0 };
-  strncpy(dev, filter, sizeof(dev) - 1);
   pci_filter_init(pacc, &pci_filter);
-  if (pci_filter_parse_slot(&pci_filter, dev))
+  if (pci_filter_parse_slot(&pci_filter, filter))
     die("Invalid device ID: %s\n", filter);
 
   if (pci_filter.bus == -1 || pci_filter.slot == -1 || pci_filter.func == -1)