X-Git-Url: http://mj.ucw.cz/gitweb/?a=blobdiff_plain;f=images%2Fobject.c;h=9133b7e6d8ff16e4d74f631ad6e12088478caf34;hb=c8c688e0b06fdacb20b28b66b9b0608dae8ca0dc;hp=d817e1c92f10c519d087073e316c2f10fc5fd242;hpb=487f19b958da5875f0c05e53d5c229874662735e;p=libucw.git diff --git a/images/object.c b/images/object.c index d817e1c9..9133b7e6 100644 --- a/images/object.c +++ b/images/object.c @@ -9,9 +9,9 @@ #undef LOCAL_DEBUG #include "sherlock/sherlock.h" -#include "lib/base224.h" -#include "lib/mempool.h" -#include "lib/fastbuf.h" +#include "ucw/base224.h" +#include "ucw/mempool.h" +#include "ucw/fastbuf.h" #include "sherlock/object.h" #include "images/images.h" #include "images/object.h" @@ -29,7 +29,7 @@ get_image_obj_info(struct image_obj_info *ioi, struct odes *o) DBG("Missing image info attribute"); return 0; } - byte color_space[MAX_ATTR_SIZE], thumb_format[MAX_ATTR_SIZE]; + byte color_space[16], thumb_format[16]; UNUSED uns cnt = sscanf(v, "%d%d%s%d%d%d%s", &ioi->cols, &ioi->rows, color_space, &ioi->colors, &ioi->thumb_cols, &ioi->thumb_rows, thumb_format); ASSERT(cnt == 7); @@ -48,9 +48,13 @@ get_image_obj_thumb(struct image_obj_info *ioi, struct odes *o, struct mempool * return 0; } uns count = 0; + uns max_len = 0; for (struct oattr *b = a; b; b = b->same) - count++; - byte buf[count * MAX_ATTR_SIZE], *b = buf; + { + count++; + max_len += strlen(b->val); + } + byte buf[max_len + 1], *b = buf; for (; a; a = a->same) b += base224_decode(b, a->val, strlen(a->val)); ASSERT(b != buf); @@ -81,16 +85,15 @@ read_image_obj_thumb(struct image_obj_info *ioi, struct fastbuf *fb, struct imag return img; error: DBG("Failed to decompress thumbnail: %s", io->thread->err_msg); - return NULL; + return NULL; } void put_image_obj_signature(struct odes *o, struct image_signature *sig) { - /* signatures should be short enough to fit one attribute */ - byte buf[MAX_ATTR_SIZE]; + /* signatures should be short enough to in a single attribute */ uns size = image_signature_size(sig->len); - ASSERT(MAX_ATTR_SIZE > BASE224_ENC_LENGTH(size)); + byte buf[BASE224_ENC_LENGTH(size) + 1]; buf[base224_encode(buf, (byte *)sig, size)] = 0; obj_set_attr(o, 'H', buf); }