xtypes: Added FIXME with possible segfault.

[libucw.git] / ucw / xtypes-basic.c

diff --git a/ucw/xtypes-basic.c b/ucw/xtypes-basic.c
index f17fc4e5ca62807f10d65fa70c8cf98c53e81365..fdb4f339ad9e7e749006ff934722edefeb037a32 100644 (file)
--- a/ucw/xtypes-basic.c
+++ b/ucw/xtypes-basic.c
@@ -2,6 +2,7 @@
  *     UCW Library -- Basic Extended Types
  *
  *     (c) 2014 Martin Mares <mj@ucw.cz>
+ *     (c) 2014 Robert Kessl <robert.kessl@economia.cz>
  *
  *     This software may be freely distributed and used according to the terms
  *     of the GNU Lesser General Public License.
@@ -11,20 +12,138 @@
 #include <ucw/mempool.h>
 #include <ucw/strtonum.h>
 #include <ucw/xtypes.h>
+#include <errno.h>
+#include <stdlib.h>
+#include <inttypes.h>
 
-static const char *xt_int_parse(const char *str, void *dest, struct mempool *pool UNUSED)
+#define XTYPE_NUM_FORMAT(_type, _fmt, _typename) static const char *xt_##_typename##_format(void *src, u32 fmt UNUSED, struct mempool *pool) \
+{\
+  return mp_printf(pool, _fmt, *(_type *)src);\
+}
+
+#define XTYPE_NUM_PARSE(_typename) static const char *xt_##_typename##_parse(const char *str, void *dest, struct mempool *pool UNUSED)\
+{\
+  return str_to_##_typename(dest, str, NULL, 10 | STN_WHOLE | STN_MINUS | STN_PLUS | STN_HEX | STN_BIN | STN_OCT);\
+}
+
+#define XTYPE_NUM_STRUCT(_type, _typename) const struct xtype xt_##_typename = {\
+  .size = sizeof(_type),\
+  .name = #_typename,\
+  .parse = xt_##_typename##_parse,\
+  .format = xt_##_typename##_format,\
+};
+
+#define XTYPE_NUM_DEF(_type, _fmt, _typename) XTYPE_NUM_FORMAT(_type, _fmt, _typename) \
+  XTYPE_NUM_PARSE(_typename)\
+  XTYPE_NUM_STRUCT(_type, _typename)
+
+XTYPE_NUM_DEF(int, "%d", int)
+XTYPE_NUM_DEF(s64, "%" PRId64, s64)
+XTYPE_NUM_DEF(intmax_t, "%jd", intmax)
+XTYPE_NUM_DEF(uint, "%u", uint)
+XTYPE_NUM_DEF(u64, "%" PRIu64, u64)
+XTYPE_NUM_DEF(uintmax_t, "%ju", uintmax)
+
+/* double */
+
+static const char *xt_double_format(void *src, u32 fmt, struct mempool *pool)
+{
+  switch(fmt) {
+  case XTYPE_FMT_RAW:
+    return mp_printf(pool, "%.10lf", *(double *)src);
+  case XTYPE_FMT_PRETTY:
+    return mp_printf(pool, "%.2lf", *(double *)src);
+  case XTYPE_FMT_DEFAULT:
+  default:
+    return mp_printf(pool, "%.5lf", *(double *)src);
+  }
+}
+
+static const char *xt_double_parse(const char *str, void *dest, struct mempool *pool UNUSED)
+{
+  char *endptr = NULL;
+  size_t sz = strlen(str);
+  errno = 0;
+  double result = strtod(str, &endptr);
+  if(endptr != str + sz) return "Could not parse double";
+  if(errno == ERANGE) return "Could not parse double: overflow happend during parsing";
+
+  *((double *) dest) = result;
+
+  return NULL;
+}
+
+const struct xtype xt_double = {
+  .size = sizeof(double),
+  .name = "double",
+  .parse = xt_double_parse,
+  .format = xt_double_format,
+};
+
+/* bool */
+
+static const char *xt_bool_format(void *src, u32 fmt UNUSED, struct mempool *pool)
+{
+  switch(fmt) {
+    case XTYPE_FMT_DEFAULT:
+    case XTYPE_FMT_PRETTY:
+      return mp_printf(pool, "%s", *((bool *)src) ? "true" : "false");
+    case XTYPE_FMT_RAW:
+      return mp_printf(pool, "%s", *((bool *)src) ? "1" : "0");
+    default:
+      die("Unsupported output type.");
+  }
+}
+
+static const char *xt_bool_parse(const char *str, void *dest, struct mempool *pool UNUSED)
+{
+  if(str[1] == 0) { // FIXME: Possible segfault
+    if(str[0] == '1') {
+      *((bool *)dest) = false;
+      return NULL;
+    }
+    if(str[0] == '1') {
+      *((bool *)dest) = true;
+      return NULL;
+    }
+  }
+
+  if(strcasecmp(str, "false") == 0) {
+    *((bool *)dest) = false;
+    return NULL;
+  }
+
+  if(strcasecmp(str, "true") == 0) {
+    *((bool *)dest) = true;
+    return NULL;
+  }
+
+  return "Could not parse bool";
+}
+
+const struct xtype xt_bool = {
+  .size = sizeof(bool),
+  .name = "bool",
+  .parse = xt_bool_parse,
+  .format = xt_bool_format,
+};
+
+/* str */
+
+static const char *xt_str_format(void *src, u32 fmt UNUSED, struct mempool *pool)
 {
-  return str_to_int(dest, str, NULL, 10 | STN_WHOLE | STN_MINUS | STN_PLUS | STN_HEX | STN_BIN | STN_OCT);
+  return mp_strdup(pool, (const char *) src);
 }
 
-static const char *xt_int_format(void *src, u32 fmt UNUSED, struct mempool *pool)
+static const char *xt_str_parse(const char *str, void *dest, struct mempool *pool UNUSED)
 {
-  return mp_printf(pool, "%d", *(int *)src);
+  *((const char **) dest) = str;
+  return NULL;
 }
 
-const struct xtype xt_int = {
-  .size = sizeof(int),
-  .name = "int",
-  .parse = xt_int_parse,
-  .format = xt_int_format,
+const struct xtype xt_str = {
+  .size = sizeof(char *),
+  .name = "str",
+  .parse = xt_str_parse,
+  .format = xt_str_format,
 };