use PciIds::Html::Forms;
use PciIds::Notifications;
use PciIds::Log;
+use PciIds::Address;
use Apache2::Const qw(:common :http);
-sub genNewItemForm( $$$$$ ) {
- my( $req, $args, $tables, $error, $values ) = @_;
+sub genNewItemForm( $$$$$$ ) {
+ my( $req, $args, $auth, $tables, $error, $values ) = @_;
my( $ok, $parent, $name, $note, $address ) = loadItem( $tables, $req->uri() );
return NOT_FOUND unless( $ok );
- my $prettyAddr = encode( $address->pretty() );
- genHtmlHead( $req, "$prettyAddr - add new item", undef );
- print "<h1>$prettyAddr - add new item</h1>\n";
+ genHtmlHead( $req, "Add new item", undef );
+ genCustomHead( $req, $args, $address, "Add new item", [ $address->canDiscuss() ? [ 'Discuss', 'newhistory' ] : (), [ 'Help', 'help', 'newitem' ], [ 'ID syntax', 'help', $address->helpName() ], [ '', 'jump' ] ], [ logItem( $auth ), [ 'Notifications', 'notifications' ] ] );
print "<div class='error'>$error</div>\n" if( defined $error );
print "<form name='newitem' id='newitem' method='POST' action=''>\n<table>";
- genFormEx( [ [ 'input', 'Id:', 'text', 'id', 'maxlength="50"' ],
+ genFormEx( [ [ 'input', 'ID:', 'text', 'id', 'maxlength="'.$address->subIdSize().'"' ],
[ 'input', 'Name:', 'text', 'name', 'maxlength="200"' ],
- [ 'input', 'Note*:', 'text', 'note', 'maxlength="1024"' ],
- [ 'textarea', 'Discussion*:', undef, 'discussion', 'rows="5" cols="50"' ],
+ [ 'input', 'Note:', 'text', 'note', 'maxlength="1024"' ],
+ [ 'textarea', 'Discussion:', undef, 'discussion', 'rows="5" cols="50"' ],
[ 'input', '', 'submit', 'submit', 'value="Submit"' ] ], $values );
print '</table></form>';
- print '<p>Items marked with * are optional.';
+ print '
+<p>
+ Please enter only accurate information. Descriptions like "Unknown modem device" are only of a little use to anybody.
+ Real chip names and numbers are preferred over marketing names. In case you know both, enclose the marketing name in square brackets like in
+ "3c595 100BaseTX [Vortex]". Do not include names of superitems in the name (like vendor name in device name).
+ Check information specific to this <a href="'.buildExcept( 'action', $args ).'?action=help?help='.$address->helpName().'">ID type</a>.
+<p>
+ If you there is something you want to clarify about the item, you can use note (like the ID does not belong to people using it).
+ Discussion is for things more relevant to history of the item than the real device (like information source).
+ Both note and discussion is optional.';
genHtmlTail();
return OK;
}
sub newItemForm( $$$$ ) {
my( $req, $args, $tables, $auth ) = @_;
if( defined $auth->{'authid'} ) {#Logged in alright
- return genNewItemForm( $req, $args, $tables, undef, {} );
+ return genNewItemForm( $req, $args, $auth, $tables, undef, {} );
} else {
return notLoggedComplaint( $req, $args, $auth );
}
( $data->{'address'}, $errstr ) = $paddress->append( $data->{'id'} );
return $errstr;
}, sub { return $paddress->canAddItem() ? undef : 'Can not add items here'; } ] );
- return genNewItemForm( $req, $args, $tables, $error, $data ) if( defined $error );
+ return genNewItemForm( $req, $args, $auth, $tables, $error, $data ) if( defined $error );
my( $result, $comName ) = $tables->submitItem( $data, $auth );
if( $result eq 'exists' ) {
genHtmlHead( $req, 'ID collision', undef );
- print '<h1>ID collision</h1>';
- print '<p>This ID already exists. Have a look <a href="/read/'.$data->{'address'}->get().'?action=list">at it</a>';
+ my $addr = PciIds::Address::new( $req->uri() );
+ genCustomHead( $req, $args, $addr, 'ID collision', [ [ 'Add other item', 'newitem' ], $addr->canDiscuss() ? [ 'Discuss', 'newhistory' ] : (), [ '', 'jump' ] ], [ logItem( $auth ) ] );
+ print '<p>Sorry, this ID already exists.';
genHtmlTail();
return OK;
} elsif( $result ) {
- die "Failed to submit new item: $result\n";
+ return genNewItemForm( $req, $args, $auth, $tables, $result, $data );
}
- notify( $tables, $data->{'address'}->get(), $comName, 2, 0 );
+ notify( $tables, $data->{'address'}->parent()->get(), $comName, 2, 0 );#Notify the parent (parent gets new items)
tulog( $auth->{'authid'}, "Item created ".$data->{'address'}->get()." ".logEscape( $data->{'name'} )." ".logEscape( $data->{'note'} )." ".logEscape( $data->{'discussion'} )." $comName" );
return HTTPRedirect( $req, '/read/'.$data->{'address'}->get().'?action=list' );
} else {
}
}
-sub genNewHistoryForm( $$$$$ ) {
- my( $req, $args, $tables, $error, $values ) = @_;
+sub genNewHistoryForm( $$$$$$ ) {
+ my( $req, $args, $tables, $auth, $error, $values ) = @_;
my( $ok, $parent, $name, $note, $address ) = loadItem( $tables, $req->uri() );
return NOT_FOUND unless( $ok );
- my $prettyAddr = encode( $address->pretty() );
- genHtmlHead( $req, "$prettyAddr - discuss", undef );
- print "<h1>$prettyAddr - discuss</h1>\n";
+ genHtmlHead( $req, "Discuss", undef );
+ genCustomHead( $req, $args, $address, "Discuss", [ $address->canAddItem() ? [ 'Add item', 'newitem' ] : (), [ 'Help', 'help', 'newhistory' ], [ '', 'jump' ] ], [ logItem( $auth ), [ 'Notifications', 'notifications' ] ] );
print "<div class='error'>$error</div>\n" if( defined $error );
print "<form name='newhistory' id='newhistory' method='POST' action=''>\n<table>";
genFormEx( [ [ 'textarea', 'Text:', undef, 'text', 'rows="5" cols="50"' ],
- [ 'input', 'Name*:', 'text', 'name', 'maxlength="200"' ],
- [ 'input', 'Note*:', 'text', 'note', 'maxlength="1024"' ],
+ [ 'input', 'Request deletion', 'checkbox', 'delete', 'value="delete"' ],
+ [ 'input', 'Name:', 'text', 'name', 'maxlength="200"' ],
+ [ 'input', 'Note:', 'text', 'note', 'maxlength="1024"' ],
[ 'input', '', 'submit', 'submit', 'value="Submit"' ] ], $values );
print '</table></form>';
- print '<p>Items marked with * are optional, use them only if you want to change the name and note.';
- print '<p>If you specify note, you must include name too.';
genHtmlTail();
return OK;
}
sub newHistoryForm( $$$$ ) {
my( $req, $args, $tables, $auth ) = @_;
if( defined $auth->{'authid'} ) {
- return genNewHistoryForm( $req, $args, $tables, undef, {} );
+ return genNewHistoryForm( $req, $args, $tables, $auth, undef, {} );
} else {
return notLoggedComplaint( $req, $args, $auth );
}
'text' => sub {
my( $expl ) = @_;
return 'Text can not be longer than 1024 characters' if ( length $expl > 1024 );
- return 'You must provide the text of comment' unless( length $expl );
+ return undef;
+ },
+ 'delete' => sub {
+ my( $delete ) = @_;
+ return ( undef, '0' ) unless defined $delete;
+ return undef if $delete eq 'delete';
+ return 'Invalid form value';
return undef;
}
}, [ sub { my( $data ) = @_;
+ return 'You must provide either name, text or request a deletion' if( ! length $data->{'name'} && ! length $data->{'text'} && ! $data->{'delete'} );
+ return undef;
+ }, sub { my( $data ) = @_;
+ return 'You can not set name and request deletion at the same time' if( length $data->{'name'} && $data->{'delete'} );
+ return undef;
+ }, sub { my( $data ) = @_;
return 'You must provide name too' if( ( length $data->{'note'} ) && ( ! length $data->{'name'} ) );
return undef;
- }, sub { return $address->canAddComment() ? undef : 'You can not discuss this item'; } ] );
- return genNewHistoryForm( $req, $args, $tables, $error, $data ) if( defined $error );
+ }, sub { return $address->canDiscuss() ? undef : 'You can not discuss this item'; } ] );
+ return genNewHistoryForm( $req, $args, $tables, $auth, $error, $data ) if( defined $error );
my $hid = $tables->submitHistory( $data, $auth, $address );
- tulog( $auth->{'authid'}, "Comment created $hid ".$address->get()." ".logEscape( $data->{'name'} )." ".logEscape( $data->{'description'} )." ".logEscape( $data->{'text'} ) );
+ tulog( $auth->{'authid'}, "Discussion created $hid ".$address->get()." ".logEscape( $data->{'name'} )." ".logEscape( $data->{'description'} )." ".logEscape( $data->{'text'} ) );
notify( $tables, $address->get(), $hid, ( defined $name && ( $name ne '' ) ) ? 1 : 0, 1 );
return HTTPRedirect( $req, '/read/'.$address->get().'?action=list' );
} else {
projects / pciids.git / blobdiff